interp: implement partial type inference#1711
Open
nelsam wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to #1710. This solves the issue I was running into before - for some reason, it got back
nilwhen looking up thecontext.Contexttype in the scope of a package I was trying to parse. That caused a nil pointer dereference.I couldn't easily reproduce it in tests. When I tried to interpret similar (but simplified) code, yaegi handled it fine.
In this case, I just added logic to skip type inference for types that come back as
nil- yaegi should probably leave it to some other context to error about that anyway.Description from #1710:
When a function has multiple type parameters, it is possible to explicitly pass in some types but rely on type inference for others. For example, func Foo[T, U any](v U) T { ... } may be called with Foostring.
This implements support for partial type inference for both indexExpr and indexListExpr ast.