fix(comparison): avoid first-sample lock in matchRatio calibration#6063
Open
ebrasha wants to merge 1 commit into
Open
fix(comparison): avoid first-sample lock in matchRatio calibration#6063ebrasha wants to merge 1 commit into
ebrasha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
kb.matchRatioused to get locked on the very first valid ratio it saw.That was fragile — if the first response happened to be noisy (CSRF token, ad slot, timestamp widget, A/B fragment), the whole baseline for that parameter ended up biased from the start.
To fix this, I switched the calibration from single-shot to multi-sample:
kb.matchRatiogets set from the median of that buffertextOnly/titlesmode), the buffer resets so old samples don't bleed into a new baselineWhy this is better
The real problem was outliers. One bad first response could throw the whole detection logic off for that parameter. Median makes those single-sample spikes basically harmless.
In practice:
Scope
Only
lib/request/comparison.pyis touched.The behavioral change is limited to how
kb.matchRatiois determined.Detection paths, ratio bounds, and decision logic stay as-is.