feat: add quiz.json for seven orphan lessons (07/15-16, 08/19, 10/15-17, 10/34)#236
feat: add quiz.json for seven orphan lessons (07/15-16, 08/19, 10/15-17, 10/34)#236BlueSkyGTM wants to merge 7 commits into
Conversation
📝 WalkthroughWalkthroughThis PR adds seven quiz JSON files across multiple lesson modules in the curriculum, each containing structured multiple-choice assessments with six questions organized into pre-, check-, and post-stage categories to support learner self-evaluation and concept reinforcement. ChangesTransformer and Optimization Technique Quizzes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
phases/10-llms-from-scratch/15-speculative-decoding-eagle3/quiz.json (1)
1-78: ⚡ Quick winAll correct answers are in position 0 across all four quiz files.
Every question in this file (and all three other quiz files in this PR) has
"correct": 0. This pattern creates predictable quizzes where learners can achieve perfect scores by always selecting the first option, reducing educational value.Consider varying the position of correct answers across questions to prevent gaming and ensure learners are genuinely engaging with the content rather than pattern-matching.
As per coding guidelines: Quiz files must follow the quiz.json schema with exactly 6 questions: 1 pre + 3 check + 2 post.
correctis zero-indexed. (The schema is met; this comment addresses quiz quality.)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@phases/10-llms-from-scratch/15-speculative-decoding-eagle3/quiz.json` around lines 1 - 78, The quiz file 15-speculative-decoding-eagle3 has every question's "correct" index set to 0, making answers predictable; update the "correct" values across the question objects so the correct option index varies (not always zero) while preserving the schema (6 questions: 1 pre, 3 check, 2 post) and keeping the explanations intact—edit the "correct" fields in each question object in the JSON to appropriate zero-based indices matching the true correct option for that question.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@phases/10-llms-from-scratch/15-speculative-decoding-eagle3/quiz.json`:
- Around line 1-78: The quiz file 15-speculative-decoding-eagle3 has every
question's "correct" index set to 0, making answers predictable; update the
"correct" values across the question objects so the correct option index varies
(not always zero) while preserving the schema (6 questions: 1 pre, 3 check, 2
post) and keeping the explanations intact—edit the "correct" fields in each
question object in the JSON to appropriate zero-based indices matching the true
correct option for that question.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8788b571-9e64-422d-b062-9b8107358d62
📒 Files selected for processing (7)
phases/07-transformers-deep-dive/15-attention-variants/quiz.jsonphases/07-transformers-deep-dive/16-speculative-decoding/quiz.jsonphases/08-generative-ai/19-visual-autoregressive-var/quiz.jsonphases/10-llms-from-scratch/15-speculative-decoding-eagle3/quiz.jsonphases/10-llms-from-scratch/16-differential-attention-v2/quiz.jsonphases/10-llms-from-scratch/17-native-sparse-attention/quiz.jsonphases/10-llms-from-scratch/34-gradient-checkpointing/quiz.json
Vercel check (not a PR defect)The failing Vercel status is \Authorization required to deploy\ — the upstream project needs a maintainer with Vercel team access to authorize deployment from this fork PR. Same as #237. This PR only adds \quiz.json\ files (no \site/, no lesson \code/). CodeRabbit passed. \�udit_lessons.py\ validates locally. Related: catalog wiring for these lessons is in #237 (README/ROADMAP only). Independent PRs; merge in either order. No graphify rebuild required for quiz-only changes. |
Summary
Adds canonical six-question
quiz.jsonfiles (1 pre / 3 check / 2 post) for seven lessons that already shipdocs/en.mdandcode/but had no on-site assessment loop.One commit per lesson (AGENTS.md convention).
Lessons
07/15-attention-variants07/16-speculative-decoding08/19-visual-autoregressive-var10/15-speculative-decoding-eagle310/16-differential-attention-v210/17-native-sparse-attention10/34-gradient-checkpointingQuestions are grounded in each lesson's
docs/en.mdand Build demos — not generic trivia.Not included
Test plan
python3 scripts/audit_lessons.pypasses on CIdocs/en.md(e.g. 07/15)