fix(stream): EventSource ignores use_file_output=False#463
Open
devteamaegis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
EventSourcesilently ignoresuse_file_output=False. The constructor assigns the flag withuse_file_output or True, butFalse or Trueevaluates toTruein Python, so the caller's intent is lost:Output tokens are still run through
transform_outputeven when the caller explicitly opted out.Why it happens
The line
self.use_file_output = use_file_output or Trueis meant to default toTruewhenNoneis passed, but it clobbers a deliberateFalseas well since Python'soroperator returns the right-hand side for any falsy left-hand side.Fix
Replace the boolean-or default with an explicit
Nonecheck: