Add more Pulp Exceptions.#1186
Merged
Merged
Conversation
aKlimau
force-pushed
the
add-pulp-exceptions
branch
8 times, most recently
from
5ebcc3a to
88bc331
Compare
jobselko
reviewed
Apr 14, 2026
aKlimau
force-pushed
the
add-pulp-exceptions
branch
5 times, most recently
from
02b7c62 to
d0d8812
Compare
jobselko
requested changes
Apr 21, 2026
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
d0d8812 to
005810f
Compare
aKlimau
force-pushed
the
add-pulp-exceptions
branch
3 times, most recently
from
510c96a to
10fe205
Compare
github-actions
Bot
removed
the
multi-commit
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
10fe205 to
c6d6bf7
Compare
jobselko
requested changes
Apr 24, 2026
aKlimau
force-pushed
the
add-pulp-exceptions
branch
3 times, most recently
from
d3c83d3 to
6698572
Compare
aKlimau
force-pushed
the
add-pulp-exceptions
branch
6 times, most recently
from
f3c5557 to
2593b03
Compare
aKlimau
force-pushed
the
add-pulp-exceptions
branch
4 times, most recently
from
c6b507c to
c31172a
Compare
Member
|
@aKlimau Can you please rebase? |
Member
|
I noticed that many of the pulp-exception changes were reverted. Could you share the reasoning behind this change? |
Contributor
Author
As we decided to treat ValidationErrors and aiohttp ClientErrors as PulpExceptions there is now no need for new classes of PulpExceptions, that's why a bunch of them were removed and old ValidationErrors were brought back. |
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
c31172a to
bceb387
Compare
jobselko
reviewed
May 27, 2026
jobselko
reviewed
May 27, 2026
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
bceb387 to
343887d
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
343887d to
0bbf087
Compare
jobselko
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Claude Sonnet 4.5 noreply@anthropic.com
📜 Checklist