doc: fix broken link in releases guide#63672
Open
parkhojeong wants to merge 1 commit into
Open
Conversation
Signed-off-by: Hojeong Park <parkhj062@gmail.com>
Collaborator
|
Review requested:
|
parkhojeong
changed the title
MikeMcC399
reviewed
May 31, 2026
Contributor
There was a problem hiding this comment.
The old file used to exist in npm v7
https://github.com/npm/cli/blame/release/v7/lib/utils/unsupported.js
The replacement file
https://github.com/npm/cli/blob/latest/lib/cli/validate-engines.js
also refers back to
https://github.com/npm/cli/blob/latest/package.json#L252-L254
"engines": {
"node": "^20.17.0 || >=22.9.0"
}where the engines definition for node has no upwards restrictions.
So I'm not sure that keeping a link to https://github.com/npm/cli/blob/latest/lib/cli/validate-engines.js is necessary or relevant.
The old non-working link should however be removed in any case.
MikeMcC399
reviewed
May 31, 2026
Comment on lines
+1341
to
1342
| upcoming release. `npm` maintains a list of [supported versions](https://github.com/npm/cli/blob/latest/lib/cli/validate-engines.js#L5) | ||
| that will need updating to include the new major release. |
Contributor
There was a problem hiding this comment.
Suggested change
| upcoming release. `npm` maintains a list of [supported versions](https://github.com/npm/cli/blob/latest/lib/cli/validate-engines.js#L5) | |
| that will need updating to include the new major release. | |
| upcoming release. |
Possibly just remove this sentence with the link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates a broken link in the release guide to point to npm CLI's current engine validation file.