Initialize Unknown States#235
Closed
rcosta358 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR initializes object instances with their default typestate (first state from each state set) when their refinement is unknown (
true).This fixes cases we try to verify an object without an explicit constructor invocation.
Also, this also improves external refinement interfaces that do not declare a constructor method.
Previously, this was required:
With this change, this is now optional.
Examples
No Explicit Constructor Call
Previously,
param.canWriteCompressed()would fail becauseparamhad unknown state (true) and it required it to be in eitherstart()or!start(), but each was checked separately since they are from different state refinements.Now
paramis initialized with the defaultstartstate.No Explicit Constructor Declaration
Previously,
isr.read()would fail becauseisrhad unknown state (true).Now
isris initialized with the defaultopenstate.Related Issue
None.
Type of Change
Checklist
liquidjava-example/src/main/java/testSuite/(Correct*/Error*)mvn testpasses locally