HITL support for react-package#17
Open
dcruzeneil2 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR is for react-package, which is not one of the specified monitored repos (kernel, infra, hypeman, hypeship). To monitor this PR anyway, reply with |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| {liveViewUrl ? ( | ||
| <div className="kma-human-intervention__iframe-wrap"> | ||
| <iframe |
There was a problem hiding this comment.
The iframe element in HumanInterventionStep.tsx is missing the sandbox attribute, which lacks protection against potential XSS and script injection attacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Embeds backend-provided
live_view_urlin an iframe during auth, which expands the attack surface if URLs are not strictly controlled server-side; otherwise UI and flow-mapping only.Overview
Adds human-in-the-loop (HITL) handling to the managed-auth React flow when the backend reports
AWAITING_HUMAN_INTERVENTION.The session hook maps that flow step to a new
awaiting_human_interventionUI state, andKernelManagedAuthrenders a dedicatedHumanInterventionStep: localized copy, an embedded live view viastate.live_view_urlwhen present (otherwise a loading indicator), and styles that widen the shell/card for the iframe. Protocol types and default/customizable localization strings for this step are included.Reviewed by Cursor Bugbot for commit d294e2d. Bugbot is set up for automated code reviews on this repo. Configure here.