fix: enhance report content handling with key-based signature on summary#565
Draft
k1LoW wants to merge 1 commit into
Draft
fix: enhance report content handling with key-based signature on summary#565k1LoW wants to merge 1 commit into
k1LoW wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
Code Metrics Report
Details | | main (182e240) | #565 (8050d22) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 51.5% | 51.3% | -0.2% |
| Files | 53 | 53 | 0 |
| Lines | 3963 | 3976 | +13 |
+ | Covered | 2042 | 2043 | +1 |
- | Code to Test Ratio | 1:0.6 | 1:0.6 | -0.1 |
| Code | 7708 | 7730 | +22 |
| Test | 4869 | 4869 | 0 |
+ | Test Execution Time | 31s | 30s | -1s |Code coverage of files in pull request scope (22.2% → 21.9%)
Benchmark-0 (this is custom metrics test)
Benchmark-1 (this is custom metrics test)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for adding report content to the GitHub Actions summary file, allowing for targeted and idempotent updates using a signature based on a key. The changes ensure that content blocks can be uniquely identified and replaced if they already exist, rather than always appending new content.
Improvements to summary file handling:
addReportContentToSummaryincmd/summary.goto accept akeyparameter, generate a unique signature, and replace existing content blocks with the same signature instead of always appending. This uses therepinlibrary for block replacement and improves idempotency and clarity of the summary file.addReportContentToSummaryincmd/root.goto pass the appropriatekeyparameter, aligning with the new function signature and behavior.