fix(create-pull-request): push branch before creating fallback issue for protected-files fallback-to-issue

[Copilot]

When protected-files: fallback-to-issue fired with the default patch-format: bundle transport, the branch was never pushed to origin. The fallback issue rendered the push-failed template (gh run download + git am recipe) instead of a compare URL — defeating the point of fallback-to-issue since reviewers couldn't inspect the diff in GitHub's UI.

The same skip logic existed in the patch (am) path, but its catch block already handled manifestProtectionFallback correctly — the skip guard just prevented it from ever running.

Changes

• Bundle transport (hasBundleFile path): remove the unconditional if (manifestProtectionFallback) { skip push; set error } guard. Move manifestProtectionFallback handling into the existing push catch block so genuine push failures (e.g. missing workflows permission) still render the push-failed template; successful pushes now reach the compare-URL template.

• Patch (am) transport: same removal — the catch block already had the right logic; the skip guard was preventing it from being reached.

• Tests: update both fallback-to-issue tests to assert the corrected behaviour — pushSignedCommits is called, issue body contains /compare/… URL, does not contain gh run download/git am.

Before (bundle path):

if (manifestProtectionFallback) {
  core.info("Skipping branch push because protected-files fallback-to-issue was triggered");
  manifestProtectionPushFailedError = new Error("Push skipped…");
} else {
  try { await pushSignedCommits(…); } catch { … }
}

After:

// push runs unconditionally; genuine failures handled in catch
try { await pushSignedCommits(…); }
catch (initialPushError) {
  if (manifestProtectionFallback) {
    manifestProtectionPushFailedError = pushError; // fall through to review-issue block
  } else if (!fallbackAsIssue) { … }
  else { /* generic push-failed issue */ }
}

---

Generated by 👨‍🍳 PR Sous Chef · gpt54 14.8M · ◷

---

Generated by 👨‍🍳 PR Sous Chef · gpt54 9.8M · ◷

[Copilot]

Pull request overview

Fixes protected-files: fallback-to-issue so that the branch is still pushed when using either bundle transport or patch (am) transport, enabling the protected-files fallback issue to include a GitHub compare URL (instead of showing push-failed “download artifact + git am” instructions when the push actually succeeded).

Changes:

• Remove the “skip push when manifestProtectionFallback is set” guard for both bundle and patch transports.
• Route manifestProtectionFallback handling through existing push catch blocks, so only genuine push failures result in push-failed instructions.
• Update tests to assert that pushSignedCommits runs and that fallback issues contain /compare/... URLs (and do not contain gh run download / git am instructions).

Show a summary per file

File	Description
actions/setup/js/create_pull_request.cjs	Always attempts branch push even under protected-files fallback, deferring to protected-files review issue logic only on genuine push failures.
actions/setup/js/create_pull_request.test.cjs	Updates protected-files fallback-to-issue tests to assert push occurs and that issue body includes a compare URL (not artifact-apply instructions).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0