[ENV] OpenApps#192
Open
taj-gillin wants to merge 16 commits into
Open
Conversation
Registers one env id per entry in openapps/config/tasks/all_tasks.yaml in addition to the generic per-app shells. Lets OpenAppsEnv take port=None and ask the OS for a free port so vectorized make stops colliding. Puts the task goal string in info["goal"] on reset/step. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
|
Hi @taj-gillin ty for the PR! Could you just provide some success rate metrics to be sure your adapatation still perform as expected? Additionally could you remove the claude code ugly comment style # --- Helper ---- etc? ty! |
# Conflicts: # stable_worldmodel/world.py
Author
|
The openapps subpackage previously owned its own FastHTML bootstrap (server thread, Hydra compose/recompose, table reset, variant discovery, task-key resolution). All of that now lives in open_apps.runtime and open_apps.tasks; this side becomes a thin wrapper around Runtime. - Delete envs/openapps/server.py and envs/openapps/paths.py. - env.py uses make_runtime / list_variants / load_task and drives variations through runtime.reconfigure(...). - envs/__init__.py auto-registers swm/OpenApps-*-v0 again, guarded by a try/except on the open_apps + playwright imports so users without the env extra are unaffected. - pyproject.toml: add open-apps and playwright to the env extra.
Neither was listed in the env's default_variations, so reset() always restored their init values and never resampled them: font_scale stayed at 1.0 (no style tag emitted) and the viewport stayed at the fixed 1024x640 the browser context is created with (set_viewport_size never fired). Drop the dead variation-space entries and their apply branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrating OpenApps with stable worldmodel