fix: ModelTrainer generates sm_train.sh with CRLF line endings on Windows causing tra (5904)#5907
Draft
sagemaker-bot wants to merge 1 commit into
Draft
Conversation
…dows causing tra (5904)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5907 +/- ##
=======================================
Coverage 89.97% 89.98%
=======================================
Files 286 286
Lines 39217 39235 +18
=======================================
+ Hits 35286 35305 +19
+ Misses 3931 3930 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AI-generated fix.
Related Issue
Related issue: 5904
Changes Made
sagemaker-train/src/sagemaker/train/model_trainer.pysagemaker-train/tests/unit/train/test_model_trainer.pyAI-Generated PR
This PR was automatically generated by the PySDK Issue Agent.
Merge Checklist
prefix: descriptionformat