Skip to content

fix: ModelTrainer generates sm_train.sh with CRLF line endings on Windows causing tra (5904)#5907

Draft
sagemaker-bot wants to merge 1 commit into
masterfrom
fix/modeltrainer-generates-sm-train-sh-with-crlf-line-5904-2
Draft

fix: ModelTrainer generates sm_train.sh with CRLF line endings on Windows causing tra (5904)#5907
sagemaker-bot wants to merge 1 commit into
masterfrom
fix/modeltrainer-generates-sm-train-sh-with-crlf-line-5904-2

Conversation

@sagemaker-bot
Copy link
Copy Markdown
Collaborator

Description

AI-generated fix.

Related Issue

Related issue: 5904

Changes Made

  • sagemaker-train/src/sagemaker/train/model_trainer.py
  • sagemaker-train/tests/unit/train/test_model_trainer.py

AI-Generated PR

This PR was automatically generated by the PySDK Issue Agent.

  • Confidence score: 95%
  • Classification: bug
  • SDK version target: V3

Merge Checklist

  • Changes are backward compatible
  • Commit message follows prefix: description format
  • Unit tests added/updated
  • Integration tests added (if applicable)
  • Documentation updated (if applicable)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.98%. Comparing base (e6905ed) to head (2759dce).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5907   +/-   ##
=======================================
  Coverage   89.97%   89.98%           
=======================================
  Files         286      286           
  Lines       39217    39235   +18     
=======================================
+ Hits        35286    35305   +19     
+ Misses       3931     3930    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant