security: reject artifact symlink escapes#5906
Open
dfgvaetyj3456356-hash wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens shared artifact tar creation so symlinks or junctions inside source/model directories cannot resolve outside the intended source root before being archived.
create_tar_file()currently opens tar archives withdereference=True, so a link inside a packaged directory can be stored as the target file contents. The new validation walks each directory source before archiving and rejects links/junctions whose resolved target is outside that source root. Plain files and links that resolve inside the source root continue to work.This also closes the temporary file descriptor returned by
mkstemp()before reopening the tar path, which fixes Windows cleanup behavior in the existing tar tests.Scope
This is packaging/upload-side hardening. It is separate from #5905, which is extraction-side validation.
Tests