Skip to content

Improve curl commands #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rob93c merged 4 commits into from
May 31, 2026
+13 −8
Merged

Improve curl commands #506

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd668a8
Configure retries for curl operations
rob93c May 30, 2026
e73dfad
Simplify curl output
rob93c May 30, 2026
965107f
Add curl parameter to fail on http errors
rob93c May 30, 2026
39e0655
Extract binary download logic into shell function
rob93c May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions .github/actions/setup-ffmpeg/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@ runs:

echo "Installing FFmpeg and FFprobe $FF_VERSION on ${{ runner.os }}"

download_binary() {
local url="$1"
local binary_name="${2:-FFmpeg}"
local output_file="$(echo "$binary_name" | tr '[:upper:]' '[:lower:]').zip"

curl -sS -f -L --retry 3 --retry-delay 5 "$url" -o "$output_file" -w "Downloaded $binary_name from %{url_effective}\n"
unzip -q "$output_file"
rm -f "$output_file"
}

if [[ "${{ runner.os }}" == "Linux" ]]; then
docker pull mwader/static-ffmpeg:$FF_VERSION
CID=$(docker create mwader/static-ffmpeg:$FF_VERSION)
Expand All @@ -28,20 +38,15 @@ runs:

elif [[ "${{ runner.os }}" == "macOS" ]]; then
FF_VERSION=$(echo "$FF_VERSION" | awk -F. '{print $1 $2}')
curl -L "https://www.osxexperts.net/ffmpeg${FF_VERSION}arm.zip" -o ffmpeg.zip
unzip -q ffmpeg.zip
download_binary "https://www.osxexperts.net/ffmpeg${FF_VERSION}arm.zip"
mv ffmpeg "$INSTALL_DIR/ffmpeg"
curl -L "https://www.osxexperts.net/ffprobe${FF_VERSION}arm.zip" -o ffprobe.zip
unzip -q ffprobe.zip
download_binary "https://www.osxexperts.net/ffprobe${FF_VERSION}arm.zip" "FFprobe"
mv ffprobe "$INSTALL_DIR/ffprobe"
chmod +x "$INSTALL_DIR/"*
rm -f ffmpeg.zip ffprobe.zip

elif [[ "${{ runner.os }}" == "Windows" ]]; then
curl -L "https://www.gyan.dev/ffmpeg/builds/packages/ffmpeg-$FF_VERSION-essentials_build.zip" -o ffmpeg.zip
unzip -q ffmpeg.zip
download_binary "https://www.gyan.dev/ffmpeg/builds/packages/ffmpeg-$FF_VERSION-essentials_build.zip"
find . -type f \( -name ffmpeg.exe -o -name ffprobe.exe \) -exec mv {} "$INSTALL_DIR/" \;
rm -f ffmpeg.zip
fi

echo "$INSTALL_DIR" >> "$GITHUB_PATH"
Expand Down
Loading