De-duplicate docker workflow pipelines#218
Merged
lelia merged 1 commit intoMay 31, 2026
Merged
Conversation
Performance (PR preview, the iterative-feedback path): - Add a concurrency group with cancel-in-progress so pushing a PR again cancels the superseded (slow) preview run instead of letting it churn. - Build preview images amd64-only. arm64 under QEMU emulation was the slowest part of the job, and preview images are for quick testing; release/stable keep multi-arch. - Enable GitHub Actions Docker layer cache (type=gha) on all image builds so unchanged layers are reused across runs. De-duplication (GitHub Actions has no YAML anchors, so use composite actions): - New .github/actions/setup-docker-publish: the QEMU + Buildx + Docker Hub login trio, shared by release.yml, pr-preview.yml, and docker-stable.yml. These had drifted to three different pinned SHA sets; now there is one. (Docker Hub creds are passed as inputs since composite actions can't read secrets directly.) - New .github/actions/setup-hatch: the pinned virtualenv/hatchling/hatch install shared by release.yml and pr-preview.yml. No behavior change to what gets published; only how the pipelines are assembled and how fast/parallel they run. Stacked on #217 (lelia/fix-dependabot-checks) to avoid a pr-preview.yml conflict with that PR's Dependabot skip; rebase onto main once #217 lands. Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.3.0.dev15Docker image: |
lelia
changed the title
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speeds up and de-duplicates the Docker publish pipelines (release / PR preview / stable). No change to what gets published — only how the workflows are assembled and how fast they run.
Speed (PR preview — the iterative path)
python-tests/dependabot-reviewalready had this; preview didn't.)type=gha) on all image builds — unchanged layers are reused across runs.De-duplication (composite actions)
GitHub Actions doesn't support YAML anchors, so the idiomatic fix is local composite actions:
.github/actions/setup-docker-publish— the QEMU + Buildx + Docker Hub login trio, previously copied into all three Docker workflows. They had drifted to three different pinned SHA sets; now there's one. (Docker Hub creds passed as inputs, since composite actions can't readsecrets.*directly.).github/actions/setup-hatch— the pinnedvirtualenv/hatchling/hatchinstall shared byrelease.ymlandpr-preview.yml.Test plan
type=gha) populates without permission errorsNotes / possible follow-ups
docker-stable.ymlstill pinsactions/checkout+build-push-actionto different SHAs than the other workflows. Left as-is — Dependabot's groupedgithub-actionsupdates will reconcile these going forward.