Add errno.EHWPOISON#7996
Conversation
📝 WalkthroughWalkthroughThis pull request adds conditional support for the ChangesEHWPOISON Error Code Addition
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/vm/src/stdlib/errno.rs (1)
736-747: ⚡ Quick winRemove redundant
target_os = "freebsd"exclusion.The
not(any(target_os = "freebsd", ...))clause includestarget_os = "freebsd", but this is already excluded by the positive conditionany(target_os = "linux", target_os = "fuchsia"). A target cannot simultaneously be both Linux/Fuchsia and FreeBSD.♻️ Simplified cfg condition
e!( cfg(all( unix, any(target_os = "linux", target_os = "fuchsia"), not(any( - target_os = "freebsd", target_os = "android", target_vendor = "apple", )) )), EHWPOISON ),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/vm/src/stdlib/errno.rs` around lines 736 - 747, The cfg expression used for the EHWPOISON entry contains a redundant exclusion "target_os = \"freebsd\"" inside the not(any(...)) list; remove that redundancy by deleting the `target_os = "freebsd"` item from the not(any(...)) clause so the e!(...) invocation that defines EHWPOISON uses cfg(all(unix, any(target_os = "linux", target_os = "fuchsia"), not(any(target_os = "android", target_vendor = "apple")))) instead—update the e! macro usage referencing EHWPOISON in errno.rs accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@crates/vm/src/stdlib/errno.rs`:
- Around line 736-747: The cfg expression used for the EHWPOISON entry contains
a redundant exclusion "target_os = \"freebsd\"" inside the not(any(...)) list;
remove that redundancy by deleting the `target_os = "freebsd"` item from the
not(any(...)) clause so the e!(...) invocation that defines EHWPOISON uses
cfg(all(unix, any(target_os = "linux", target_os = "fuchsia"), not(any(target_os
= "android", target_vendor = "apple")))) instead—update the e! macro usage
referencing EHWPOISON in errno.rs accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: d176aad6-2650-43cf-b3dc-f169d02f2776
📒 Files selected for processing (1)
crates/vm/src/stdlib/errno.rs
Summary
Summary by CodeRabbit