Skip to content

fix: gracefully fail when node module can't be found #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 2 commits into from
May 29, 2026
+12 −2
Merged

fix: gracefully fail when node module can't be found #6037

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be805e4
fix: gracefully fail when node module can't be found
edusperoni May 28, 2026
7f99acb
Merge origin/main and resolve plugins-service conflicts
Copilot May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/services/plugins-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,17 @@ This framework comes from ${dependencyName} plugin, which is installed multiple
): INodeModuleData {
// module can be modulePath or moduleName
if (!this.$fs.exists(module) || path.basename(module) !== "package.json") {
module = this.getPackageJsonFilePathForModule(module, projectDir);
const resolvedPath = this.getPackageJsonFilePathForModule(
module,
projectDir,
);
if (!resolvedPath) {
this.$logger.warn(
`Could not find module ${color.yellow(module)}. It may have been removed or is not installed. Skipping.`,
);
return null;
}
module = resolvedPath;
}

const data = this.$fs.readJson(module);
Expand Down Expand Up @@ -759,7 +769,7 @@ This framework comes from ${dependencyName} plugin, which is installed multiple
const nodeModules = this.getDependencies(projectData.projectDir);
return _.map(nodeModules, (nodeModuleName) =>
this.getNodeModuleData(nodeModuleName, projectData.projectDir),
);
).filter(Boolean);
}

private async executeNpmCommand(
Expand Down