hal: Add new types and API framework for the getter/setter change.#4099
hal: Add new types and API framework for the getter/setter change.#4099BsAtHome wants to merge 1 commit into
Conversation
grandixximo
left a comment
There was a problem hiding this comment.
After this all out-of-tree components must be recompiled, add a note in the commit message? Not that anyone reads those...
| volatile rtapi_sint _s; \ | ||
| volatile rtapi_uint _u; \ | ||
| volatile rtapi_real _r; \ | ||
| } |
There was a problem hiding this comment.
Small thought on the __hal_mapped_type union: since it gets type-punned against hal_data_u (a different union type), strict aliasing technically applies. The RT side is covered because RTFLAGS adds -fno-strict-aliasing, but the userspace ULAPI build runs at -O2 without it, so there the access leans on the volatile members to stay well-behaved. Would it be worth tagging the union with __attribute__((__may_alias__)) to make it portably safe in both builds regardless of flags? Happy to defer if you think the volatile guarantee already covers it.
| { | ||
| va_list ap; | ||
| va_start(ap, fmt); | ||
| int ret = hal_param_new_newapi(HAL_BIT, dir, (void**)ref, compid, fmt, ap); |
There was a problem hiding this comment.
used (void**)ref here and ref in the others, unify the style?
| type_, dirmap[dir_], to_c(name)), file=f) | ||
| if isnewtype: | ||
| dflt = "%s" % value if value is not None else "0" | ||
| print(" r = hal_param_new_%s(comp_id, %s, &(inst->%s_p), %s," % ( |
There was a problem hiding this comment.
these should be back to 4 spaces, they are outside the for block...
This is the first in a series of updates to move HAL pin and param access over to getter/setter methods and eliminate direct user access to the underlying data. This PR sets the stage and puts the type, data and access infrastructure in place.
The new data interface is neither slower nor faster than direct access. All access is expanded through inline function expansion. The new interface prevents access to the wrong data because access is strongly typed and clearly separates the application and implementation layers.
The new interface will replace the current HAL types when we perform the API break. The new types are (underlying type in parentheses):
hal_real_t- (rtapi_real) floating pointhal_sint_t- (rtapi_sint) 64-bit signed integerhal_uint_t- (rtapi_uint) 64-bit unsigned integerhal_bool_t- (rtapi_bool) booleanhal_port_t- (rtapi_sint) [not yet exposed because a change breaks the current API]The new HAL types cannot be dereferenced and the compiler will emit an error if you try:
You must use the proper access functions:
rtapi_<type> hal_get_<type>(hal_<type>_t pin)rtapi_<type> hal_set_<type>(hal_<type>_t pin, rtapi_<type> value)rtapi_s32 hal_get_si32(hal_sint_t pin)rtapi_s32 hal_get_si32_clamped(hal_sint_t pin)rtapi_u32 hal_get_ui32(hal_uint_t pin)rtapi_u32 hal_get_ui32_clamped(hal_uint_t pin)rtapi_s32 hal_set_si32(hal_sint_t pin, rtapi_s32 value)rtapi_u32 hal_set_ui32(hal_uint_t pin, rtapi_u32 value)This change also makes it clear that setting a pin is not possible with simple assignment. The setter and getter are not valid lvalues. Both can be used as rvalues. The 32-bit compatibility works as expected and is transparent for the user API. All current code will be updated to use the
si32andui32variants where appropriate. Then, when all code is upgraded, we can start fixing the code to be 64-bit clean. The*_clamped()versions read the larger type and convert to the smaller type with min/max bounds.The distinction 32/64 bit will be gone completely in the underlying data once all code uses the getter/setter access. That is the point where the user relevant code can be changed and break the API to eliminate userspace visible 32-bit values (i.e. HAL_S32, HAL_U32, HAL_S64, HAL_U64 type indicators will vanish and replaced by HAL_SINT and HAL_UINT).
A new set of pin/param creation functions have been made that use the underlying old API for compatibility until we do the full API break. New pins and params are created with:
int hal_pin_new_<type>(int comp_id, hal_pdir_t direction, hal_<type>_t *pinref, rtapi_<type> dflt, const char *namefmt, ...)int hal_param_new_<type>(int comp_id, hal_pdir_t direction, hal_<type>_t *paramref, rtapi_<type> dflt, const char *namefmt, ...)There are two additional pin/param new functions that use the
si32andui32markers. These are there for compatibility with the current system such that we can use both APIs concurrently until all code has been updated/fixed/ported. They can be eliminated once all code is 64-bit clean with respect to pin and param use and access.The underlying HAL pin/param structures have been adapted to match each other's layout. Access to params are treated the same as pins from the user's (component) perspective and the underlying structure types will be merged in a future PR. This also allows to merge the lists and use a RB-tree for faster access from the python interface (halmodule).
The
halcompileprogram, to create components, has been updated to support the new types. It is an addition to the status quo so we can use both systems while we migrate. Using the new types is as easy as:Note that setting a pin must be done using the
<pinname>_set()format. Reading a pin is transparant in halcompile compiled programs (just like today). An update for all components is already in the pipeline to be submitted after this PR is merged. Halcompile can drop the old style types once everything is moved over and we do the API break.