fix(interp): reset G52/G92 offsets on prog_stop when DISABLE_G92_PERSISTENCE=1#4098
Open
Sigma1912 wants to merge 1 commit into
Open
fix(interp): reset G52/G92 offsets on prog_stop when DISABLE_G92_PERSISTENCE=1#4098Sigma1912 wants to merge 1 commit into
Sigma1912 wants to merge 1 commit into
Conversation
Sigma1912
force-pushed
the
fix_g52_g92_reset_on_m2
branch
from
eb25871 to
af6cdf8
Compare
Sigma1912
force-pushed
the
fix_g52_g92_reset_on_m2
branch
3 times, most recently
from
4dd8afd to
96bb95a
Compare
…ISTENCE=1 This fixes LinuxCNC#4096 - Adds canonical command to actually reset applied G92/G52 offset on M2,M30 with [RS274NGC] 'DISABLE_G92_PERSISTENCE = 1' - Updates INI documentation on DISABLE_G92_PERSISTENCE to reflect new behavior and agree with 'GCODE' documentation - Modify the 'g92-offset-persistence' test to account for the added 'SET_G92_OFFSET(0.0000, 0.0000, 0.0000, 0.0000, 0.0000, 0.0000)' - Change type to 'bool' rather than 'int'
Sigma1912
force-pushed
the
fix_g52_g92_reset_on_m2
branch
from
96bb95a to
7e9c891
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4096
The current code only resets the parameter values to zero but does not actually reset the applied G92 offset values.