Calculate number of nodes in the tree estimators#214
Open
avolkov-intel wants to merge 1 commit into
Open
Conversation
| and isinstance(iterations[0], Union[Numeric, NumpyNumeric].__args__) | ||
| ): | ||
| metrics.update({"iterations": int(iterations[0])}) | ||
| if hasattr(estimator_instance, "estimators_"): |
Contributor
There was a problem hiding this comment.
This will also be set in other types of estimators - for example:
https://scikit-learn.org/stable/modules/generated/sklearn.multiclass.OneVsRestClassifier.html
Perhaps it could check if the first entry there is of tree type.
Also what about cuML? I guess it could be done by calling as_sklearn():
https://docs.rapids.ai/api/cuml/nightly/pickling_cuml_models/#Converting-Between-cuML-and-scikit-learn-Models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
n_nodes) for Random Forest and Extra Trees estimators after trainingn_nodesas an indifferent metric in the report so it's compared across libraries rather than treated as a grouping parameterChecklist:
Completeness and readability
Testing