Stable 1.83.19 Hotfix

[neon-nyan]

What's changed? - 1.83.19

• [Imp] Update NuGet, Submodules and Bump Version
• [Fix][Hi3 Game Settings] Throw while saving empty game settings
• [Fix][Hi3 Game Repair] Audio_Default.pck keeps getting redownloaded after game repair
• [Fix][Hi3 Game Repair] Data hash calculation based on MhyMurmurHash264B (like Blocks and Audio files) sometimes causes exception if data length doesn't match
• [Imp][Hi3 Game Repair] Use Hardware/SIMD-based (AVX2) on addition operation for BSDiff patching (for Block and Audio files)

  It will fallback to scalar method if no AVX2 support is present.

• [Fix][Hi3 Game Repair] HTTP 404 (Not Found) error for some present CGs (including Birthday and In-game cutscenes)
• [Fix] Preload progress not updating to 100% on Sophon method
• [Fix][HSR Game Repair] Honkai: Star Rail v4.3 Broke Game Repair and Cache Updates due to changes on Internal Game Struct format.
  • [HSR 4.3] Adjustment on data struct (DesignDataV)
  • [HSR 4.3] Adjustment on data struct (IFixV)
• [Fix][Hi3 Game Repair] Wrong VA files getting downloaded on Mainland China Servers

Full Changelog: CL-v1.83.18...CL-v1.83.19

Code Signing Policy

Free code signing provided by SignPath.io, certificate by SignPath Foundation

• This program will not transfer any information to other networked systems.
• Read our full Privacy Policy
• Also read our Third Party Notices for license used by third party libraries that we use.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	microsoft.web.webview2@​1.0.3912.50 ⏵ 1.0.3967.48
	microsoft.windowsappsdk.foundation@​2.0.20 ⏵ 2.0.21
	microsoft.windowsappsdk.interactiveexperiences@​2.0.12 ⏵ 2.0.13
	microsoft.windowsappsdk.winui@​2.0.12 ⏵ 2.1.0
	microsoft.extensions.logging.abstractions@​10.0.7 ⏵ 10.0.8
	microsoft.windowsappsdk.ai@​2.0.185 ⏵ 2.1.10
	microsoft.net.illink.tasks@​10.0.8
	microsoft.extensions.dependencyinjection@​10.0.7 ⏵ 10.0.8
	microsoft.extensions.dependencyinjection.abstractions@​10.0.7 ⏵ 10.0.8
	microsoft.extensions.logging@​10.0.7 ⏵ 10.0.8
	microsoft.extensions.options@​10.0.7 ⏵ 10.0.8
	microsoft.extensions.primitives@​10.0.7 ⏵ 10.0.8
	microsoft.win32.systemevents@​10.0.7 ⏵ 10.0.8
	system.io.hashing@​10.0.7 ⏵ 10.0.8
	system.security.cryptography.protecteddata@​10.0.7 ⏵ 10.0.8
	system.commandline@​2.0.7 ⏵ 2.0.8
	sentry@​6.5.0 ⏵ 6.6.0
	google.protobuf@​3.34.1 ⏵ 3.35.0
	markdig.signed@​1.1.3 ⏵ 1.2.0
	microsoft.windows.ai.machinelearning@​2.0.300 ⏵ 2.1.1			+2
	microsoft.windowsappsdk@​2.0.1 ⏵ 2.1.3
	microsoft.windowsappsdk.base@​2.0.3 ⏵ 2.0.4
	microsoft.windowsappsdk.dwrite@​2.0.26041403 ⏵ 2.1.0
	microsoft.windowsappsdk.ml@​2.0.300 ⏵ 2.1.1
	microsoft.windowsappsdk.widgets@​2.0.4 ⏵ 2.0.5
	system.drawing.common@​10.0.7 ⏵ 10.0.8
	velopack@​0.0.1298 ⏵ 1.1.1	+3
	costura.fody@​6.1.0 ⏵ 6.2.0
	microsoft.windowsappsdk.runtime@​2.0.1 ⏵ 2.1.3

View full report

[sentry]

Bug: The SIMD loop processes uninitialized ArrayPool memory when reading the end of a file, causing the patched output file to be corrupted.
_{Severity: HIGH}

Suggested Fix

The SIMD addition loops should be modified to only process the number of bytes actually read into the oldData buffer, which is availableInputBytes. Alternatively, the rented ArrayPool buffer could be zero-initialized before use to prevent processing garbage data.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: CollapseLauncher/Classes/RepairManagement/BSDiff.cs#L329-L332

Potential issue: In the `BSDiff.cs` patching logic, when processing the end of an input
file, the number of bytes read into the `oldData` buffer (`availableInputBytes`) can be
less than the buffer's full size (`CBufferSize`). However, the subsequent SIMD
processing loops iterate over the entire `oldData` buffer, including the uninitialized
portion containing garbage data from the `ArrayPool`. This garbage data is then added to
the `newData` buffer and written to the output file, causing file corruption. This issue
occurs whenever the patching process reaches the end of the input file.

_{Did we get this right? 👍 / 👎 to inform future reviews.}