Populate DbType for PostgreSql#3645
Draft
unattendedfaxmachine wants to merge 12 commits into
Draft
Conversation
…_TYPE and ensure that timezone is configured to UTC for standardization
…e are anyways returning UtcDateTime
…s.DATETIMEOFFSET_TYPE
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
This PR is to address #3094, which is a bug that happens because the default type conversion for C# to Npgsql is to convert a string to a TEXT field, but this doesn't work when trying to compare a DATE type for PostgreSql databases.
This PR is a consolidation/continuation/experimentation of prior work here:
What is this change?
My change passes the column name of the Postgres column attempting to be filtered through to the filtering context, and then we override PopulateDbTypeForParameter to pass the DBType value through to Npgsql, much like how this is done for MsSql. This hopefully means that Npgsql knows to convert the C# string into something that works with the DATE (and every other) column type.
How was this tested?
(Currently untested)
Sample Request(s)
With query:
Before:
(Hopefully After):