Do not make 'describe table' query when schema is known#1845
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
|
||
| auto remote_function = TableFunctionFactory::instance().get(remote_query, new_context); | ||
|
|
||
| std::shared_ptr<TableFunctionRemote> remote_table_function = std::dynamic_pointer_cast<TableFunctionRemote>(remote_function); |
There was a problem hiding this comment.
Nit: I would add a comment stating why we can set the structure for remote table functions. And possible scope the remote_table_function to an if statement, something like:
if (auto remote_table_function = cast(remote_function))
{
...
}
But this is a minor, no need to do it
Audit — PR #1845: Do not make
|
Verification Report: PR #1845 — Skip
|
| CI status | RED (15 fail/error jobs) |
| Block merge on CI? | No — most red is flake, infra, or combinatorial regression noise |
| Server change risk | Low–medium; builds green, iceberg regression green; no clear upstream regression signal |
What matters in the red CI
Not PR regressions
| Failure | Why ignore for #1845 |
|---|---|
| 1124 regression "new fails" (swarms, parquet, s3_export) | Fail rates identical base vs PR (swarms 37.5%, parquet 5.0%, etc.) — combinatorial diff, not rate increase |
| Stateless targeted (3 tests) + stress s3 | Flaky on master; targeted job runner crashed |
| Integration 4/6, 1/5 (interrupted) | Infra/cascade (test_sync_replica, mass iceberg FAILs at one timestamp) |
test_namespace_filter |
Fails on CREATE TABLE in setup, before the filter logic under test; root cause unknown. ~15% fail rate on master (90d) — not #1845-specific |
Tracked separately
| Failure | Note |
|---|---|
test_remote_initiator_after_non_remote[s3] |
Test/harness issue, not a server regression from #1845. Fix in PR #1856 (Fix test_remote_initiator_after_non_remote — updates test_remote_initiator.py + cluster config). Also flaky on master (~9% fail rate). |
What passed
All builds · fast test · SQLLogic · unit tests · most stateless/integration · iceberg regression (both suites, both arches) · parquet minio/aws_s3 · docker/grype.
Recommendation
- Merge decision should not hinge on CI red alone for this PR.
test_namespace_filter— investigate setupCREATE TABLEfailure independently of Do not make 'describe table' query when schema is known #1845.test_remote_initiator_after_non_remote— follow #1856, not Do not make 'describe table' query when schema is known #1845.- Optional: confirm skipped-DESCRIBE schema matches remote DESCRIBE for
remote/s3Clusterpaths (swarms/parquet failure patterns match the change, but rates don't worsen vs base).
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Do not make 'describe table' query when schema is known
Documentation entry for user-facing changes
With 'object_storage_remote_initiator' setting query to Iceberg table converted to
remote(.., iceberg(...))remotetable function callsdescribe tableby default to resolve remote table schema.But when table is from DataLake catalog, schema already known, 'describe table' query can be avoided.
CI/CD Options
Exclude tests:
Regression jobs to run: