Release new version (with fixes for pickling)?

[csm10495]

Hey folks,

Recent versions of frozenlist seem to not be pickleable. The latest version on pypi is 1.7.0:

In [1]: import frozenlist

In [2]: import pickle

In [3]: f = frozenlist.FrozenList([1,2])

In [4]: pickle.loads(pickle.dumps(f))
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[4], line 1
----> 1 pickle.loads(pickle.dumps(f))

File <stringsource>:2, in frozenlist._frozenlist.FrozenList.__reduce_cython__()

TypeError: self._frozen cannot be converted to a Python object for pickling

In [5]: frozenlist.__version__
Out[5]: '1.7.0'

.. so we fail to pickle on 1.7.0.

However on the latest git hash: d973b7a, it seems to work just fine:

In [1]: import pickle

In [2]: import frozenlist

In [3]: f = frozenlist.FrozenList([1,2])

In [4]: pickle.loads(pickle.dumps(f))
Out[4]: <FrozenList(frozen=False, [1, 2])>

In [5]: f.freeze()

In [6]: pickle.loads(pickle.dumps(f))
Out[6]: <FrozenList(frozen=True, [1, 2])>

In [7]: frozenlist.__version__
Out[7]: '1.7.1.dev0'

Can there be a new release to pypi that has this fixed? Thanks!

[csm10495]

@webknjaz any chance for a new release?

[Vizonex]

@csm10495 I could look into fixing it if you want. Perhaps I could write a pytest for it as well.

[csm10495]

I think its already fixed in the latest main. It just hasn't been released to pypi yet.

[webknjaz]

Sorry, it fell off the radar. @bdraco made a release 3 weeks ago so I'm assuming this is resolved.

[csm10495]

@webknjaz @bdraco I think between when I first tested this on d973b7a and the release of 1.8.0, this broke again. So the latest version (1.8.0) still is broken with pickle. Same thing with e300cd8.

I don't have permission to reopen, would you like a new issue for this?

[webknjaz]

@csm10495 do you think you could submit a PR with a regression test?

[Vizonex]

@webknjaz I could put it into my pr if you want #712 otherwise I can make another branch for testing pickling.

[csm10495]

Ah hey, we sort of did it at the same time. I also have: #718 .. Whatever works: works with me :)